Re: [PATCH] pack-object: tolerate broken packs that have duplicated objects

From: Shawn Pearce <spearce@spearce.org>
Date: Nov 17, 2011, 20:49 UTC
Message-ID: <CAJo=hJsB_V0n8af0BPZs+qyQ3pVqBrb1xv8qfpifKgUJO=shTw@mail.gmail.com>
In-Reply-To: <7v8vnfnv3g.fsf@alter.siamese.dyndns.org>

On Wed, Nov 16, 2011 at 22:04, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> When --reuse-delta is in effect (which is the default), and an existing
> pack in the repository has the same object registered twice (e.g. one copy
> in a non-delta format and the other copy in a delta against some other
> object), an attempt to repack the repository can result in a cyclic delta
> dependency, causing write_one() function to infinitely recurse into
> itself.
>
> Detect such a case and break the loopy dependency by writing out an object
> that is involved in such a loop in the non-delta format.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Looks sane to me, thanks.