Re: [PATCH] travis-ci: run scan-build every time

From: Samuel Lijin <sxlijin@gmail.com>
Date: Feb 26, 2017, 02:09 UTC
Message-ID: <CAJZjrdXg=jTXO+Dox9gTby-_JX+Lw_deihbUmbHe8V92dWJ0tg@mail.gmail.com>
In-Reply-To: <BAB1EE0E-B258-4108-AE24-110172086DE4@gmail.com>

On Sat, Feb 25, 2017 at 3:48 PM, Lars Schneider <larsxschneider@gmail.com> wrote:

Show 16 quoted lines

>
>> On 24 Feb 2017, at 18:29, Samuel Lijin <sxlijin@gmail.com> wrote:
>>
>> It's worth noting that there seems to be a weird issue with scan-build
>> where it *will* generate a report for something locally, but won't do it
>> on Travis. See [2] for an example where I have a C program with a
>> very obvious memory leak but scan-build on Travis doesn't generate
>> a report (despite complaining about it in stdout), even though it does
>> on my local machine.
>>
>> [1] https://travis-ci.org/sxlijin/git/builds/204853233
>> [2] https://travis-ci.org/sxlijin/travis-testing/jobs/205025319#L331-L342
>
> Scan-build stores the report in some temp folder. I assume you can't access
> this folder on TravisCI. Try the scan-build option "-o scan-build-results"
> to store the report in the local directory.

That occurred to me, but I don't quite think that's the issue. I just noticed that on the repo I use to test build matrices, jobs 1-8 don't generate a report, but 9-14 and 19-20 do [1]. I don't think it's an issue with write permissions (scan-build complains much more vocally if that happens), but it doesn't seem to matter if the output dir is in the tmpfs [2] or a local directory [3].

[1] https://travis-ci.org/sxlijin/travis-testing/builds/205054253 [2] https://travis-ci.org/sxlijin/git/jobs/205028920#L1000 [2] https://travis-ci.org/sxlijin/git/jobs/205411705#L998

Show 11 quoted lines

>> @@ -78,9 +79,8 @@ before_install:
>>       brew update --quiet
>>       # Uncomment this if you want to run perf tests:
>>       # brew install gnu-time
>> -      brew install git-lfs gettext
>> -      brew link --force gettext
>> -      brew install caskroom/cask/perforce
>> +      brew install git-lfs gettext caskroom/cask/perforce llvm
>> +      brew link --force gettext llvm
>
> This wouldn't be necessary if we only scan on Linux.

Agreed. I'm not sure if macOS static analysis would bring any specific benefits; I don't really have much experience with static analysis tools one way or another, so I'm happy to defer on this decision.

>> -script: make --quiet test
>> +script: scan-build make --quiet test
>
> Why do you want to scan the tests?

Brain fart on my end.

> Cheers,
> Lars