Re: [BUG] git p4 clone fails when p4 sizes does not return 'fileSize' key
- From
- Thandesha VK <thanvk@gmail.com>
- Date
- Apr 17, 2018, 17:21 UTC
- Message-ID
- <CAJJpmi9OQicqEonVwWMo+yimU5MBdJ9gwzbtY1GXSMB+E69AGA@mail.gmail.com>
- In-Reply-To
- <cover.1523981210.git.amazo@checkvideo.com>
*I* think keeping the filesize info is better with --verbose option as that gives some clue about the file we are working on. What do you think? Script has similar checks of key existence at other places where it is looking for fileSize.
On Tue, Apr 17, 2018 at 9:22 AM, Andrey Mazo <amazo@checkvideo.com> wrote:
Show 16 quoted lines
> Huh, I actually have a slightly different fix for the same issue. > It doesn't suppress the corresponding verbose output completely, but just removes the size information from it. > > Also, I'd mention that the workaround is trivial -- simply omit the "--verbose" option. > > Andrey Mazo (1): > git-p4: fix `sync --verbose` traceback due to 'fileSize' > > git-p4.py | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > > base-commit: 468165c1d8a442994a825f3684528361727cd8c0 > -- > 2.16.1 >
-- Thanks & Regards Thandesha VK | Cellphone +1 (703) 459-5386