Re: What's cooking in git.git (Apr 2012, #11; Sun, 29)

From: David Aguilar <davvid@gmail.com>
Date: May 2, 2012, 06:04 UTC
Message-ID: <CAJDDKr7qzKUdQgr--6fPxa89qmo-KTaXT+UzLxosuJwBXPNbwQ@mail.gmail.com>
In-Reply-To: <7vbomahu1h.fsf@alter.siamese.dyndns.org>

On Sun, Apr 29, 2012 at 6:45 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> --------------------------------------------------
> [Cooking]
>
> * th/difftool-diffall (2012-04-23) 8 commits
>  - difftool: print list of valid tools with '--tool-help'
>  - difftool: teach difftool to handle directory diffs
>  - difftool: eliminate setup_environment function
>  - difftool: stop appending '.exe' to git
>  - difftool: remove explicit change of PATH
>  - difftool: exit(0) when usage is printed
>  - difftool: add '--no-gui' option
>  - difftool: parse options using Getopt::Long
>
> Rolls the two-directory-diff logic from diffall script (in contrib/) into
> "git difftool" framework.
>
> What's the doneness of this topic?  David?

It looks good to me. I've tested it and haven't seen anything unexpected so far.

I was happy to see it "just work" when I tried it on both Linux and OS X.

-- 
David