git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] documentation fix: git difftool uses diff tools, not merge tools.

From
David Aguilar <davvid@gmail.com>
Date
Nov 21, 2011, 12:25 UTC
Message-ID
<CAJDDKr6vrWqZ_KcyDeGWbiy41ncRtgj9OgF9rSW+YxZZJBFK7Q@mail.gmail.com>
In-Reply-To
<7v62imi6c7.fsf@alter.siamese.dyndns.org>
On Mon, Nov 14, 2011 at 4:20 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 36 quoted lines
> Thomas Hochstein <thh@inter.net> writes:
>
>> Let the documentation for -t list valid *diff* tools,
>> not valid *merge* tools.
>>
>> Signed-off-by: Thomas Hochstein <thh@inter.net>
>> ---
>>  Documentation/git-difftool.txt |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Documentation/git-difftool.txt b/Documentation/git-difftool.txt
>> index a03515f..19d473c 100644
>> --- a/Documentation/git-difftool.txt
>> +++ b/Documentation/git-difftool.txt
>> @@ -31,7 +31,7 @@ OPTIONS
>>  -t <tool>::
>>  --tool=<tool>::
>>       Use the diff tool specified by <tool>.
>> -     Valid merge tools are:
>> +     Valid diff tools are:
>>       araxis, bc3, diffuse, emerge, ecmerge, gvimdiff, kdiff3,
>>       kompare, meld, opendiff, p4merge, tkdiff, vimdiff and xxdiff.
>>  +
>
> The patch is obviously correct, and it is so trivial that there is no risk
> of breaking anything. It would even be OK for 1.7.7.X maintenance series.
>
> But in the longer term, I suspect that we would want to drop this
> enumeration from the documentation, and instead give "--list-tools"
> option or something to the command. That way, we only need to keep
> the list of known tools in one place where it matters, namely, the
> command that knows about them.
>
> David, what do you think?
>
> The same comment applies to "git mergetool", I would think.
Exactly my thoughts.
-- 
    David
Previous: Junio C Hamano
Message 3 of 3 in “documentation fix: git difftool uses diff tools, not merge tools.”
  1. documentation fix: git difftool uses diff tools, not merge tools.Thomas Hochstein, Nov 14, 2011
  2. Junio C HamanoNov 15, 2011
  3. David AguilarNov 21, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.