Re: [PATCH] contrib/completion: fix remote completion for "git push/remote"
- From
David Aguilar <davvid@gmail.com>
- Date
- May 30, 2021, 03:32 UTC
- Message-ID
- <CAJDDKr4rVLYxPpwEg3K4Ok1XUeKhupthPehyKczhHYmFFMF_0Q@mail.gmail.com>
- In-Reply-To
- <CAPig+cTOFySGeUKM2oa9nHmkGVaWUbq8ghcid0hHxxSbV6jAjg@mail.gmail.com>
On Sat, May 29, 2021 at 8:12 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 6 quoted lines
> > On Sat, May 29, 2021 at 10:49 PM David Aguilar <davvid@gmail.com> wrote: > > If __git_cmd_idx is empty then zsh will silelntly fail to > > complete remotes when doing "git push <tab>". > > s/silelntly/silently/
Thanks! I'm going to wait a bit for the completion experts to chime in before I prepare a v2.
For v2, I'm thinking it might make sense to go ahead and squash both of the completion changes into a single patch.
(sorry for the noisy resend -- I wasn't in text mode so vger dropped the original reply)
-- David