git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] mergetools: add support for DeltaWalker

From
David Aguilar <davvid@gmail.com>
Date
Mar 3, 2012, 22:00 UTC
Message-ID
<CAJDDKr4q7gmFeHuGM5hFruduHw-3mGa+CMU=U6X0jjXUsJLsvw@mail.gmail.com>
In-Reply-To
<7vaa3ybpat.fsf@alter.siamese.dyndns.org>
On Fri, Mar 2, 2012 at 2:39 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> Tim Henigan <tim.henigan@gmail.com> writes:
>
>>  mergetools/DeltaWalker |   12 ++++++++++++
>
> How does an end user choose to use this backend?  Perhaps like this?
>
>    $ git mergetool --tool=DeltaWalker
>
> All the other files in mergetools/ are in lower case, and I _strongly_
> prefer to have this new file also be in lower case.
I agree.
Show 24 quoted lines
> Such a change may mean you may have to override translate_merge_tool_path
> in this file, like some other backends seem to do.
>
>>  1 file changed, 12 insertions(+)
>>  create mode 100644 mergetools/DeltaWalker
>>
>> diff --git a/mergetools/DeltaWalker b/mergetools/DeltaWalker
>> new file mode 100644
>> index 0000000..b9e6618
>> --- /dev/null
>> +++ b/mergetools/DeltaWalker
>> @@ -0,0 +1,12 @@
>> +diff_cmd () {
>> +     "$merge_tool_path" "$LOCAL" "$REMOTE" >/dev/null 2>&1
>> +}
>> +
>> +merge_cmd () {
>> +     if $base_present
>> +     then
>> +             "$merge_tool_path" "$LOCAL" "$REMOTE" "$BASE" -merged="$PWD/$MERGED"
>> +     else
>> +             "$merge_tool_path" "$LOCAL" "$REMOTE" -merged="$PWD/$MERGED"
>> +     fi >/dev/null 2>&1
>> +}

Is the $PWD/ prefix strictly needed? The rest of the mergetools use $MERGED as-is. Does it work without it?

-- 
David
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 8 in “mergetools: add support for DeltaWalker”
  1. mergetools: add support for DeltaWalkerTim Henigan, Mar 2, 2012
  2. Junio C HamanoMar 2, 2012
  3. David AguilarMar 3, 2012
  4. Junio C HamanoMar 3, 2012
  5. Tim HeniganMar 4, 2012
  6. David AguilarMar 5, 2012
  7. Junio C HamanoMar 5, 2012
  8. Tim HeniganMar 5, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.