Re: [PATCH v8] checkout: extend --track with a "fetch" mode to refresh start-point
Show 8 quoted lines
> I do not quite see the point of this extra block. Can we do without
> it (and move the def of oid up near the beginning of the function,
> of course)?
>
> Even better, as resolve_fetch_target() already looks at "arg" and
> poked at the remote-tracking ref hierarchy, wouldn't it make more
> sense to make that helper function responsible for finding out if
> there already is a usable, albeit potentially stale, ref?
Done. Can I get another review here please?
Show 9 quoted lines
> > @@ -1244,7 +1398,6 @@ static int git_checkout_config(const char *var, const char *value,
> > opts->dwim_new_local_branch = git_config_bool(var, value);
> > return 0;
> > }
> > -
> > if (starts_with(var, "submodule."))
> > return git_default_submodule_config(var, value, NULL);
>
> Unrelated patch noise?