Re: [PATCH] Documentation: networking: device drivers: Remove stray asterisks

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Dec 1, 2019, 14:28 UTC
Message-ID: <CAHk-=wj9P8ukXOuTUnpkPNwc8B683Z0Za=-WxpLygMbjEtNxgA@mail.gmail.com>
In-Reply-To: <xmqqblss1rjp.fsf@gitster-ct.c.googlers.com>

On Sat, Nov 30, 2019 at 10:35 PM Junio C Hamano <gitster@pobox.com> wrote:

>
> OK, so it appears that the tool is working as documented.

Well, yes and no.

I think it's a mistake that --no-keep-cr (which is the default) only acts on the outer envelope.

Now, *originally* the outer envelope was all that existed so it makes sense in a historical context of "CR removal happens when splitting emails in an mbox". And that's the behavior we have.

But then git learnt to do MIME decoding and extracting things from base64 etc, and the CR removal wasn't updated to that change.

I guess "documented" is arguable in the sense that the git documentation does talk about "git-mailsplit" as an implementation detail, but still..

             Linus