git/list[1] front-page[2] threads[3] people[4] search[5] about
 

git ssh signing changed broke tag merge message contents

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Jan 10, 2022, 16:42 UTC
Message-ID
<CAHk-=whXPxWL7z3GiPkaDt+yygrRmagrYUnib7Lx=Vvrqx2ufg@mail.gmail.com>

So I made the mistake of updating my git tree as I started doing my merge window for 5.17, and suddenly all the messages from signed tags disappeared from the merge commits.

I bisected it to commit 02769437e1 ("ssh signing: use sigc struct to pass payload"), but haven't done any other analysis.

I assume it's the change to fmt-merge-msg.c, but have no time to actually check.
Easy enough to test:
   echo "Dummy file" > dummy
   git commit -m "Dummy commit" dummy
   git tag -s -m "Dummy tag" dummy-tag
   git reset --hard HEAD^
   git merge --no-ff dummy-tag

With the above, you are *supposed* to get a merge message in your editor something like

    Merge tag 'dummy-tag'
    Dummy tag
    * tag 'dummy-tag':
      Dummy commit
(ok, that last part you only get with merge.summary=true, of course)

But with the broken commit, that "Dummy tag" message from the tag contents does not exist.

Holler if there are questions, but I'm hoping the above explanation is clear enough since I'm about to be very busy..

                Linus
Next: Taylor Blau
Message 1 of 8 in “git ssh signing changed broke tag merge message contents”
  1. Linus TorvaldsJan 10, 2022
  2. Taylor BlauJan 10, 2022
  3. Linus TorvaldsJan 10, 2022
  4. Junio C HamanoJan 10, 2022
  5. fmt-merge-msg: prevent use-after-free with signed tagsTaylor Blau, Jan 10, 2022
  6. Junio C HamanoJan 10, 2022
  7. Fabian StelzerJan 11, 2022
  8. Taylor BlauJan 11, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.