Re: [Bug Report] Git fails to compile with fortify-headers and LTO - error: inlining failed in call to 'always_inline' 'fwrite': function body can be overwritten at link time

From: Immolo <immoloism@googlemail.com>
Date: Jul 18, 2023, 23:18 UTC
Message-ID: <CAHfWF5mjquES-nocQaK+CAEsqWgdy-_OYdGtN82heYs0eJP3eQ@mail.gmail.com>
In-Reply-To: <xmqqcz0oerup.fsf@gitster.g>

I've reported to the folks over at fortify-headers already and they came to the same conclusion (minus GCC), it's an odd one that's for sure.

Immolo

On Wed, 19 Jul 2023 at 00:13, Junio C Hamano <gitster@pobox.com> wrote:

Show 19 quoted lines

>
> Immolo <immoloism@googlemail.com> writes:
>
> > /usr/include/fortify/stdio.h: In function 'verify_cache':
> > /usr/include/fortify/stdio.h:59:28: error: inlining failed in call to
> > 'always_inline' 'fwrite': function body can be overwritten at link
> > time
> >    59 | _FORTIFY_FN(fwrite) size_t fwrite(const void *__d, size_t __n,
> > size_t __m, FILE *__f)
> >       |                            ^
> > cache-tree.c:175:33: note: called from here
> >   175 |                                 fprintf(stderr, "...\n");
> >       |                                 ^
>
> It looks like a plain vanilla invocation of fprintf(), unlike from
> any random application, a user of the standard C runtime library .
> Is this a bug to be reported here, or would it be more valuable and
> useful if reported to GCC or Fortify folks, I wonder?
>