Re: What's cooking in git.git (Nov 2019, #02; Fri, 8)
- From
Matheus Tavares Bernardino <matheus.bernardino@usp.br>
- Date
- Nov 14, 2019, 06:35 UTC
- Message-ID
- <CAHd-oW7UPSSExyLtfLMCObWogKrBOctYabrFrOdf9-4Q2PZmMg@mail.gmail.com>
- In-Reply-To
- <CAHd-oW6vBm6JnN8aSeryC716+7xzV-LBZujeRgZgF6RbP0LLHg@mail.gmail.com>
On Fri, Nov 8, 2019 at 12:00 PM Matheus Tavares Bernardino <matheus.bernardino@usp.br> wrote:
Show 27 quoted lines
> > Hi, Junio > > On Fri, Nov 8, 2019 at 5:41 AM Junio C Hamano <gitster@pobox.com> wrote: > [...] > > > > * mt/threaded-grep-in-object-store (2019-10-02) 11 commits > > - grep: move driver pre-load out of critical section > > - grep: re-enable threads in non-worktree case > > - grep: protect packed_git [re-]initialization > > - grep: allow submodule functions to run in parallel > > - submodule-config: add skip_if_read option to repo_read_gitmodules() > > - grep: replace grep_read_mutex by internal obj read lock > > - object-store: allow threaded access to object reading > > - replace-object: make replace operations thread-safe > > - grep: fix racy calls in grep_objects() > > - grep: fix race conditions at grep_submodule() > > - grep: fix race conditions on userdiff calls > > > > Traditionally, we avoided threaded grep while searching in objects > > (as opposed to files in the working tree) as accesses to the object > > layer is not thread-safe. This limitation is getting lifted. > > > > What's the current status of this one? > > This was the last round of improvements I had in mind for this topic. > So for my part, I think this is ready.
In fact, Jonathan Tan recently pointed out an issue[1] in this topic, regarding the possibility of a race condition with the reading windows. So I'll work on a new version.
[1]: https://public-inbox.org/git/20191112025418.254880-1-jonathantanmy@google.com/