git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] unpack-trees: do not set SKIP_WORKTREE on submodules

From
Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date
Jun 18, 2020, 20:29 UTC
Message-ID
<CAHd-oW7S1NKtwy=LdV95Nw-FPbLyUDV34BXLzd1D7Y6g29AtbQ@mail.gmail.com>
In-Reply-To
<CABPp-BHV6iKH4PS6Gqfhe6piBdgmZ9D+cgXvSJ+dNcw-UHD-+w@mail.gmail.com>
On Thu, Jun 18, 2020 at 4:20 PM Elijah Newren <newren@gmail.com> wrote:
Show 21 quoted lines
>
> On Thu, Jun 18, 2020 at 7:34 AM Matheus Tavares Bernardino
> <matheus.bernardino@usp.br> wrote:
> >
> > On Wed, Jun 17, 2020 at 9:24 PM Elijah Newren <newren@gmail.com> wrote:
> > >
> > > When we notice an initialized submodule that does not match the
> > > sparsity patterns, we should print a warning just like we do for
> > > unmerged and dirty entries.
> >
> > Yeah, seems like a good approach. Thanks for the explanations. Some of
> > the test cases in mt/grep-sparse-checkout will have to be adjusted
> > with this change. Should I reroll the series based on the patch you
> > will send or do you prefer to adjust them in your patch (and make it
> > dependent on mt/grep-sparse-checkout)?
>
> Ah, good catch.  Your series came first, is longer, and is reviewed
> other than the submodule/config stuff that needs someone more familiar
> with that area than me.  Since my patch needs more work anyway, how
> about I rebase my patch on top of your work, and make sure to ping you
> as a reviewer to make sure I don't mess anything up?
Sounds good :) Thanks
Previous: Elijah Newren
Message 6 of 6 in “unpack-trees: do not set SKIP_WORKTREE on submodules”
  1. unpack-trees: do not set SKIP_WORKTREE on submodulesElijah Newren via GitGitGadget, Jun 17, 2020
  2. Matheus Tavares BernardinoJun 17, 2020
  3. Elijah NewrenJun 18, 2020
  4. Matheus Tavares BernardinoJun 18, 2020
  5. Elijah NewrenJun 18, 2020
  6. Matheus Tavares BernardinoJun 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.