Re: [PATCH 2/2] hex: make hash_to_hex_algop() and friends thread-safe

From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Jun 25, 2020, 23:54 UTC
Message-ID: <CAHd-oW7GzbtWONYiE9RHQRSzeB1gGvbojJEzdKSMg7qQTMCuOw@mail.gmail.com>
In-Reply-To: <20200625230753.GB9782@camp.crustytoothpaste.net>

On Thu, Jun 25, 2020 at 8:08 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 13 quoted lines

>
> On 2020-06-25 at 20:32:57, Matheus Tavares wrote:
> > +#ifdef HAVE_THREADS
> > +     void *value;
> > +
> > +     if (pthread_once(&hexbuf_array_once, init_hexbuf_array_key))
> > +             die(_("failed to initialize threads' key for hash to hex conversion"));
> > +
> > +     value = pthread_key_getspecific(&hexbuf_array_key);
>
> I think the portable name for this is "pthread_getspecific".  That
> appears to be what POSIX specifies and what our Windows pthread compat
> code uses.

Right, thanks for noticing that!

(I wonder how the Windows build passed successfully in our CI [1]... Shouldn't the compiler have failed due to a "undefined reference" error?)

[1]: https://github.com/matheustavares/git/runs/808649609