git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] clean: remove unnecessary variable

From
Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date
May 6, 2021, 21:14 UTC
Message-ID
<CAHd-oW6oN7=8DwzEFmCXdSWRcvzpqGEKFDkTMzN3uP1M9Cphrg@mail.gmail.com>
In-Reply-To
<YJRLim10cznG5G3d@coredump.intra.peff.net>
On Thu, May 6, 2021 at 5:03 PM Jeff King <peff@peff.net> wrote:
Show 6 quoted lines
>
> Definitely not necessary, but on a patch like this I'll sometimes
> manually specify "-U4" (and I always have diff.interhunkcontext set to
> "1") to show the complete code between the declaration and use. It makes
> it even more obvious that the result is correct (though obviously
> applying and compiling shows it, too). #gitlifehacks
That's a good idea, thanks for the advice :)
Previous: Jeff KingNext: Elijah Newren
Message 3 of 4 in “clean: remove unnecessary variable”
  1. clean: remove unnecessary variableMatheus Tavares, May 6, 2021
  2. Jeff KingMay 6, 2021
  3. Matheus Tavares BernardinoMay 6, 2021
  4. Elijah NewrenMay 6, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.