Re: [PATCH v3 0/9] docs: de-duplicate sections, add more CONFIGURATION sections

From: Matheus Tavares <matheus.bernardino@usp.br>
Date: Sep 3, 2022, 13:29 UTC
Message-ID: <CAHd-oW4QpPBUqo5ToWXtBg7-LHbEam7aqSALSrwaA3OABma8ng@mail.gmail.com>
In-Reply-To: <cover-v3-0.9-00000000000-20220831T083759Z-avarab@gmail.com>

Hi, Ævar

Thanks for the reroll. I looked at the range-diff, and you've addressed almost all of my comments from the previous version. I only spot one issue:

On Wed, Aug 31, 2022 at 5:41 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 24 quoted lines

>
> Range-diff against v2:
> [...]
>  8:  5c379ab1476 !  8:  af912e9ca65 docs: add CONFIGURATION sections that map to a built-in
>     @@ Documentation/git-fast-import.txt: operator can use this facility to peek at the
>       --------
>       linkgit:git-fast-export[1]
>
>     + ## Documentation/git-init.txt ##
>     +@@ Documentation/git-init.txt: $ git commit    <3>
>     + <2> Add all existing files to the index.
>     + <3> Record the pristine state as the first commit in the history.
>     +
>     ++CONFIGURATION
>     ++-------------
>     ++
>     ++include::includes/cmd-config-section-all.txt[]
>     ++
>     ++include::config/init.txt[]
>     ++
>     + GIT
>     + ---
>     + Part of the linkgit:git[1] suite
>     +

Shouldn't this change be part of commit 9 instead of 8?