git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] doc: sparse-checkout: mention --cone option

From
Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date
Jan 24, 2020, 01:51 UTC
Message-ID
<CAHd-oW4NM_ZdCeW_HBZxcZrd47v3uMn96t+nHLZt3Pe3R6vfWw@mail.gmail.com>
In-Reply-To
<CAN0heSq3gvZeUXnqzbjFY-1axmFXEJDO4oRp9abRO8TuxJQuDw@mail.gmail.com>
Hi, Martin
On Thu, Jan 23, 2020 at 5:28 PM Martin Ågren <martin.agren@gmail.com> wrote:
Show 29 quoted lines
>
> Hi Matheus,
>
> On Thu, 23 Jan 2020 at 20:02, Matheus Tavares <matheus.bernardino@usp.br> wrote:
> > In af09ce2 ("sparse-checkout: init and set in cone mode", 2019-11-21),
> > the '--cone' option was added to 'git sparse-checkout init'. Add this
> > option to the respective doc file.
>
> Nit: s/respective/corresponding/
>
> "Respective" sounds -- to me at least -- like you're tweaking two
> different files. Maybe that's just me.
>
> >  To avoid interfering with other worktrees, it first enables the
> >  `extensions.worktreeConfig` setting and makes sure to set the
> >  `core.sparseCheckout` setting in the worktree-specific config file.
> > ++
> > +When `--cone` is provided the `core.sparseCheckoutCone` setting is also
>
> Nit: maybe add a comma after "provided". Without it, I could see someone
> false-starting the parsing as "provided with the" or even "provided to
> the". Those readings obviously don't work out in the end, but with an
> extra comma, I think it's easier to just naturally read this the way
> it's intended.
>
> > +set, allowing for better performance with a limited set of patterns
> > +(see 'CONE PATTERN SET' bellow).
>
> s/bellow/below/

Thanks for the comments. Junio has already addressed them[1] when picking up the patch :)

[1]: https://github.com/gitster/git/commit/a402723e488c66bd12cf674c332f185fee1d2347
Previous: Martin ÅgrenNext: Matheus Tavares
Message 4 of 6 in “sparse-checkout: add completion and --cone to docs”
  1. 0/2 sparse-checkout: add completion and --cone to docsMatheus Tavares, Jan 23, 2020
  2. 1/2 doc: sparse-checkout: mention --cone optionMatheus Tavares, Jan 23, 2020
  3. Martin ÅgrenJan 23, 2020
  4. Matheus Tavares BernardinoJan 24, 2020
  5. 2/2 completion: add support for sparse-checkoutMatheus Tavares, Jan 23, 2020
  6. Derrick StoleeJan 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.