git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] pkt-line: support tracing verbatim pack contents

From
AFAugie Fackler <augie@google.com>
Date
Jun 16, 2015, 16:52 UTC
Message-ID
<CAHcr6HbKfE=B502t9hJt601-mco+PK9s4uViFW3AkHABubiF0w@mail.gmail.com>
In-Reply-To
<20150616164310.GA18667@peff.net>
On Tue, Jun 16, 2015 at 12:43 PM, Jeff King <peff@peff.net> wrote:
Show 16 quoted lines
> On Tue, Jun 16, 2015 at 09:39:19AM -0700, Junio C Hamano wrote:
>
>> As to the documentation, I have a feeling that, unless the reader
>> and/or the user intimately knows that TRACE_PACK is implemented by
>> hooking into the same mechanism that TRACE_PACKET needs to, s/he
>> would not even wonder if TRACE_PACKET needs to be enabled when
>> asking for TRACE_PACK.  Yes, one is a proper substring of the other,
>> but the similarity between the two stops there.  While I do not
>> think it would hurt very much to mention that they are independent,
>> I have a slight suspicion that it might make it more likely to get
>> user confused.
>
> Yes, I was just re-reading the documentation based on Augie's comment,
> and it seems pretty clear to me. Of course I wrote it, so that is not
> saying much. Augie, I'd be happy to hear a proposed wording change if
> you have one.

Yeah, I don't have one - I may have been making assumptions because I knew something of the background on your implementation. i'd say let it live and if people provide feedback later figure out a reword (writing for humans is not a strong suit of mine, alas.)

Show 5 quoted lines
>
> I do kind of hate the name TRACE_PACK for two reasons:
>
>   - it _is_ so close to TRACE_PACKET; maybe TRACE_PACKFILE would be
>     better

+1 on TRACE_PACKFILE - also makes it harder to accidentally leave off the ET and get binary spew when one didn't expect that.

AF
Previous: Jeff KingNext: Jeff King
Message 17 of 33 in “fetch-pack: optionally save packs to disk”
  1. fetch-pack: optionally save packs to diskAugie Fackler, Jun 11, 2015
  2. Johannes SixtJun 12, 2015
  3. Junio C HamanoJun 12, 2015
  4. Augie FacklerJun 12, 2015
  5. Jeff KingJun 12, 2015
  6. Jeff KingJun 12, 2015
  7. 1/3 pkt-line: simplify starts_with checks in packet tracingJeff King, Jun 12, 2015
  8. Stefan BellerJun 12, 2015
  9. 2/3 pkt-line: tighten sideband PACK check when tracingJeff King, Jun 12, 2015
  10. Stefan BellerJun 12, 2015
  11. Jeff KingJun 12, 2015
  12. Stefan BellerJun 12, 2015
  13. 3/3 pkt-line: support tracing verbatim pack contentsJeff King, Jun 12, 2015
  14. Augie FacklerJun 16, 2015
  15. Junio C HamanoJun 16, 2015
  16. Jeff KingJun 16, 2015
  17. Augie FacklerJun 16, 2015
  18. Jeff KingJun 16, 2015
  19. Jeff KingJun 16, 2015
  20. Augie FacklerJun 16, 2015
  21. Jeff KingJun 16, 2015
  22. Augie FacklerJun 16, 2015
  23. 0/3 add GIT_TRACE_STDINJeff King, Jun 16, 2015
  24. 1/3 trace: implement %p placeholder for filenamesJeff King, Jun 16, 2015
  25. 2/3 trace: add pid to each output lineJeff King, Jun 16, 2015
  26. 3/3 trace: add GIT_TRACE_STDINJeff King, Jun 16, 2015
  27. Jeff KingJun 16, 2015
  28. Jeff KingJun 16, 2015
  29. Duy NguyenJun 17, 2015
  30. Jeff KingJun 17, 2015
  31. Duy NguyenJun 18, 2015
  32. Junio C HamanoJun 26, 2015
  33. Augie FacklerJun 12, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.