Re: [PATCH 1/1] fast-import: checkpoint: dump branches/tags/marks even if object_count==0

From: Eric Rannaud <e@nanocritical.com>
Date: Sep 28, 2017, 20:30 UTC
Message-ID: <CAH_=xoY_WihdNEeZTcUyYR8jFu17L0gnS8umLToOR6ER0A=RSQ@mail.gmail.com>
In-Reply-To: <xmqqo9pv156t.fsf@gitster.mtv.corp.google.com>

On Thu, Sep 28, 2017 at 3:35 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> "Eric Rannaud" <e@nanocritical.com> writes:
>
>> +# The commands in input_file should not produce any output on the file
>> +# descriptor set with --cat-blob-fd (or stdout if unspecified).
>
> Thanks for documenting this.  Swapping the order of starting
> fast-import and feeding its input (which is one change in this
> version relative to the previous one) alone would not help, because
> in the updated order in this patch, nobody is reading from
> fast-import until the parent process finishes feeding it.

Darn. That's correct, on a platform with blocking pipes it would not work. I will start the input cat in the background (so it may block while writing), before reading from the output of fast-import.