git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] refs/files: keep root refs out of loose ref cache

From
Andy Koppe <andy.koppe@gmail.com>
Date
Oct 19, 2026, 21:30 UTC
Message-ID
<CAHWeT-azx6pHvUGy=-Jp+gjbErsJvJ3StTms4twLvoM50+a=zQ@mail.gmail.com>
In-Reply-To
<atWxNvZn3CYTBuFp@pks.im>
On Mon, 19 Oct 2026 at 06:57, Patrick Steinhardt wrote:
Show 10 quoted lines
> On Sat, Oct 17, 2026 at 09:04:00PM +0100, Andy Koppe wrote:
> > Changes since v1:
> > - Move create_root_ref_cache() below get_loose_ref_cache() for a smaller
> >   diff, and tweak its comment.
> > - Correct the documentation, help text and refs.h comment for
> >   `--include-root-refs`, which claimed that it lists pseudorefs.
> > - Consider alternative approaches in the log message.
>
> It would help to also get a range-diff relative to v1 so that a reviewer
> can see what exxactly has changed between the two versions.
Done with v3, relative to v1.
Show 17 quoted lines
> > diff --git a/Documentation/for-each-ref-options.adoc b/Documentation/for-each-ref-options.adoc
> > index 54e2fa95c2..b93ffbd74d 100644
> > --- a/Documentation/for-each-ref-options.adoc
> > +++ b/Documentation/for-each-ref-options.adoc
> > @@ -73,7 +73,8 @@ TAB %(refname)`.
> >       using the same rules as _<pattern>_ above.
> >
> >  `--include-root-refs`::
> > -     List root refs (`HEAD` and pseudorefs) apart from regular refs.
> > +     List root refs such as `HEAD` and `ORIG_HEAD` in addition to regular
> > +     refs. (The pseudorefs `FETCH_HEAD` and `MERGE_HEAD` are not included.)
> >
> >  `--start-after=<marker>`::
> >      Allows paginating the output by skipping references up to and including the
>
> These changes make sense, but they are unrelated to the fix. They should
> thus go into a separate commit.

Dropped from v3. I'll put them into a separate patch, along with other fixes for outdated uses of "pseudoref".

Andy
Previous: Patrick SteinhardtNext: Andy Koppe
Message 9 of 13 in “refs/files: keep root refs out of loose ref cache”
  1. refs/files: keep root refs out of loose ref cacheAndy Koppe, Oct 14, 2026
  2. Patrick SteinhardtOct 15, 2026
  3. Junio C HamanoOct 15, 2026
  4. Andy KoppeOct 15, 2026
  5. Patrick SteinhardtOct 16, 2026
  6. Junio C HamanoOct 16, 2026
  7. refs/files: keep root refs out of loose ref cacheAndy Koppe, Oct 17, 2026
  8. Patrick SteinhardtOct 19, 2026
  9. Andy KoppeOct 19, 2026
  10. refs/files: keep root refs out of loose ref cacheAndy Koppe, Oct 19, 2026
  11. Patrick SteinhardtOct 20, 2026
  12. Junio C HamanoOct 21, 2026
  13. Patrick SteinhardtOct 21, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.