Re: [PATCH] Makefile: pin cargo --target-dir to ./target
- From
Andy Koppe <andy.koppe@gmail.com>
- Date
- Oct 20, 2026, 20:05 UTC
- Message-ID
- <CAHWeT-aD9pNEdWHVf+M9dXzav1P7dTD+h4mQ8c4gkrpvdYxTxA@mail.gmail.com>
- In-Reply-To
- <xmqq7bjcxqkr.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> > Andy Koppe <andy.koppe@gmail.com> writes: > > > The problem I see with that approach is that CARGO_ARGS looks like it > > is intended for build preferences similar to CFLAGS or LDFLAGS that > > could be overridden on the make command line, whereas the target dir > > is a hard requirement of the subsequent link step. > > > > I suppose `override CARGO_ARGS += --target-dir target` would avoid > > that concern, but also set a trap because any subsequent modifications > > of the variable without `override` would be quietly ignored. > > But we are already tweaking it with += in the Makefile, aren't we? > > # Rust flags > CARGO_ARGS = > ifndef V > CARGO_ARGS += --quiet > endif > ifndef DEBUG > CARGO_ARGS += --release > endif
Yes, but those are preferences that can be overridden on the make command line without doing harm (within reason), similar to the default 'CFLAGS = -g -O2 -Wall', whereas the --target-dir should always be passed to ensure the cargo output is going where it's expected.