git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] utf8: add display_mode_esc_sequence_len_counted()

From
Andy Koppe <andy.koppe@gmail.com>
Date
Nov 17, 2026, 23:08 UTC
Message-ID
<CAHWeT-Zt=1MjD=fbOiAiQtb28Q4DAR_wF12iymXmeXzGyyLgbQ@mail.gmail.com>
In-Reply-To
<xmqqqzgjcjes.fsf@gitster.g>
Junio C Hamano wrote:
> -       while (isdigit(*p) || *p == ';')
> +       while (p < end && (isdigit(*p) || *p == ';'))
While you're there, could you add colons (':') to that?

ECMA-48 §5.4.2 defines them as sub-separators within the semicolon-separated parameters of control sequences. Colons are referred to as "3/10" there, aka ASCII 0x3A:

https://ecma-international.org/wp-content/uploads/ECMA-48_5th_edition_june_1991.pdf#page=26

Maybe more practically relevant, xterm and its many more-or-less-compatible brethren accept colons in SGR sequences:

"xterm allows either colons (standard) or semicolons (legacy) to separate the subparameters (but after the first colon, colons must be used)" https://invisible-island.net/xterm/ctlseqs/ctlseqs.html

Andy
Previous: Dirk GoudersNext: Junio C Hamano
Message 8 of 15 in “utf8: make display_mode_esc_sequence_len() take a length”
  1. utf8: make display_mode_esc_sequence_len() take a lengthJunio C Hamano, Nov 17, 2026
  2. utf8: add display_mode_esc_sequence_len_counted()Junio C Hamano, Nov 17, 2026
  3. Dirk GoudersNov 17, 2026
  4. Junio C HamanoNov 17, 2026
  5. Dirk GoudersNov 17, 2026
  6. Junio C HamanoNov 18, 2026
  7. Dirk GoudersNov 18, 2026
  8. Andy KoppeNov 17, 2026
  9. Junio C HamanoNov 17, 2026
  10. Andy KoppeNov 18, 2026
  11. Dirk GoudersNov 18, 2026
  12. Andy KoppeNov 18, 2026
  13. Dirk GoudersNov 18, 2026
  14. Andy KoppeNov 18, 2026
  15. Dirk GoudersNov 18, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.