git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git log -p unexpected behaviour

From
John Tapsell <johnflux@gmail.com>
Date
May 1, 2013, 07:23 UTC
Message-ID
<CAHQ6N+rs1miLLUWsGvu5W-nUxU9NK30JEo8gcjXpdGLLXvqK7g@mail.gmail.com>
In-Reply-To
<7vvc73bvp9.fsf@alter.siamese.dyndns.org>
On 30 April 2013 21:38, Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> John Tapsell <johnflux@gmail.com> writes:
>
>> On 30 April 2013 20:44, Junio C Hamano <gitster@pobox.com> wrote:
>>> John Tapsell <johnflux@gmail.com> writes:
>>>
>>>> Is there no way to fix --cc to work even in the edge cases?
>>>
>>> Can you clarify what you mean by "fix" and "edge cases"?
>>
>> My understanding is that even with -cc there will be changes that
>> won't be seen - and hence why --cc could be even more of a "security
>> risk", no?
>
> Combined diff is a way to show a tricky conflict resolved in a
> tricky way, so that the tricky-ness of the resolution can be
> examined.  A trivial resolution that takes one side is not shown
> because it is not usually interesting.

I don't really understand your point sorry. In this trivial resolution case, you would still just see the commit that added the code in a later commit. No?

There couldn't be a case where you add or change a line of code, but not see it with --cc ?

Show 7 quoted lines
> This design choice of course
> have to trust people involved in the project do not pull from
> untrustworthy sources.
>
> You would need "log -p -m" (without any pathspec) for the kind of
> "security" you are talking about.  Note that "-p -m --first-parent"
> is not necessarily enough.
This results in seeing the same change more than once though, right?
Previous: Junio C HamanoNext: shawn wilson
Message 20 of 22 in “git log -p unexpected behaviour - security risk?”
  1. John TapsellApr 11, 2013
  2. Tay Ray ChuanApr 11, 2013
  3. Simon RuderichApr 20, 2013
  4. Junio C HamanoApr 21, 2013
  5. John TapsellApr 21, 2013
  6. Jonathan NiederApr 21, 2013
  7. John TapsellApr 21, 2013
  8. Thomas RastApr 21, 2013
  9. Jonathan NiederApr 21, 2013
  10. Junio C HamanoApr 21, 2013
  11. John SzakmeisterApr 30, 2013
  12. Junio C HamanoApr 30, 2013
  13. John SzakmeisterApr 30, 2013
  14. Matthieu MoyApr 30, 2013
  15. John SzakmeisterApr 30, 2013
  16. John TapsellApr 30, 2013
  17. Junio C HamanoApr 30, 2013
  18. John TapsellApr 30, 2013
  19. Junio C HamanoApr 30, 2013
  20. John TapsellMay 1, 2013
  21. shawn wilsonApr 30, 2013
  22. Junio C HamanoApr 21, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.