git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/8] mergetools: use the correct tool for Beyond Compare 3 on Windows

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Oct 16, 2011, 10:11 UTC
Message-ID
<CAHGBnuPoV0-9ZY9MffB2KTxPyK0TQiPcyZg-bH9WYo7HCS+QKA@mail.gmail.com>
In-Reply-To
<7vty79vrdn.fsf@alter.siamese.dyndns.org>
On Sat, Oct 15, 2011 at 22:14, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
>>> Hmm, does this only apply to Windows, or are there other platforms on
>>> which BC3 supplies bcomp for the exact same reason? What I am trying to
>>
>> BC3 is only available for Linux and Windows, so it only applies to
>> Windows currently.
>
> Who asked anything about "currently"?

Heh, no one. But obviously I cannot predict the future, that's why I explicitly said "currently".

Here's what I was meaning to say in more long-winded words: Although BC3 only supports Linux and Windows currently, IMHO it is unlikely that future support for other platforms will suffer from the same issue as Windows and will require a different executable than "bcompare". And even if it was the case, that could be fixed then. For now the proposed patch covers all cases and works well, and although your suggestion would be more generic, it's not necessary, and the discussion about whether or not to use your more generic approach is starting to outweigh the time that was required to write this patch as well as the time that would be required for a future patch.

-- 
Sebastian Schuberth
Previous: Junio C HamanoNext: Pat Thoyts
Message 20 of 21 in “Some patches from msysGit”
  1. 0/8 Some patches from msysGitPat Thoyts, Oct 14, 2011
  2. 1/8 t1020: disable the pwd test on MinGWPat Thoyts, Oct 14, 2011
  3. 2/8 t1402: Ignore a few cases that must fail due to DOS path expansionPat Thoyts, Oct 14, 2011
  4. Junio C HamanoOct 15, 2011
  5. Pat ThoytsOct 15, 2011
  6. Junio C HamanoOct 15, 2011
  7. 3/8 t9001: do not fail only due to CR/LF issuesPat Thoyts, Oct 14, 2011
  8. 4/8 git-svn: On MSYS, escape and quote SVN_SSH also if set by the userPat Thoyts, Oct 14, 2011
  9. 5/8 t9901: fix line-ending dependency on windowsPat Thoyts, Oct 14, 2011
  10. Junio C HamanoOct 15, 2011
  11. Pat ThoytsOct 15, 2011
  12. 6/8 t9300: do not run --cat-blob-fd related tests on MinGWPat Thoyts, Oct 14, 2011
  13. 7/8 mergetools: use the correct tool for Beyond Compare 3 on WindowsPat Thoyts, Oct 14, 2011
  14. Junio C HamanoOct 15, 2011
  15. Sebastian SchuberthOct 15, 2011
  16. Pat ThoytsOct 15, 2011
  17. Sebastian SchuberthOct 16, 2011
  18. Sebastian SchuberthOct 16, 2011
  19. Junio C HamanoOct 15, 2011
  20. Sebastian SchuberthOct 16, 2011
  21. 8/8 mingw: ensure sockets are initialized before calling gethostnamePat Thoyts, Oct 14, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.