git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: clarify that notes can be attached to any type of stored object

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Apr 4, 2016, 08:10 UTC
Message-ID
<CAHGBnuPkPqJprOxR4zBuWitXqXt9XtpnjGPQWEv+-pYovh1b+A@mail.gmail.com>
In-Reply-To
<xmqqy48xjqg5.fsf@gitster.mtv.corp.google.com>
On Fri, Apr 1, 2016 at 5:31 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 25 quoted lines
> Sebastian Schuberth <sschuberth@gmail.com> writes:
>
>> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
>> ---
>>  Documentation/git-notes.txt | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt
>> index 8de3499..5375d98 100644
>> --- a/Documentation/git-notes.txt
>> +++ b/Documentation/git-notes.txt
>> @@ -234,8 +234,9 @@ which operation triggered the update, and the commit authorship is
>>  determined according to the usual rules (see linkgit:git-commit[1]).
>>  These details may change in the future.
>>
>> -It is also permitted for a notes ref to point directly to a tree
>> -object, in which case the history of the notes can be read with
>> +It is also permitted for a notes ref to point to any other object in
>> +the object store besides commit objects, that is annotated tags, blobs
>> +or trees. For the latter, the history of the notes can be read with
>>  `git log -p -g <refname>`.
>
> I do not think this is correct place to patch.  The original is not
> talking about what objects can have notes attached at all.  What it
> explains is this.

Thanks for the explanation, I was indeed misreading this. I'll try to clarify this section then, too. In order to do so, I think we should mention how to actually create a <refname> that directly points to a tree instead of a commit for the history of notes. Would you have an example how to do that?

-- 
Sebastian Schuberth
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 8 in “doc: clarify that notes can be attached to any type of stored object”
  1. doc: clarify that notes can be attached to any type of stored objectSebastian Schuberth, Apr 1, 2016
  2. Junio C HamanoApr 1, 2016
  3. Junio C HamanoApr 1, 2016
  4. Sebastian SchuberthApr 4, 2016
  5. doc: Clarify which objects notes can be attached toSebastian Schuberth, Apr 4, 2016
  6. Junio C HamanoApr 4, 2016
  7. Sebastian SchuberthApr 4, 2016
  8. Junio C HamanoApr 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.