git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] blame.c: Properly initialize strbuf after calling, textconv_object()

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Oct 31, 2011, 17:57 UTC
Message-ID
<CAHGBnuPN9z_yntJPqGOWVFWc7PteWMfC8HV9UZoEYN-Z56xwyQ@mail.gmail.com>
In-Reply-To
<7vd3dht4ms.fsf@alter.siamese.dyndns.org>
On Fri, Oct 28, 2011 at 19:20, Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
>>>>> Thanks; do you have no addition to the test suite to demonstrate the
>>>>> breakage?
>>>>
>>>> Not yet. I'll try to come up with something.
>>>
>>> Let's do this.
>>
>> Thanks, but that does not seem to work for me. The test breaks both
>> without and with my patch. I'll look into it.
>
> Thanks. I suspect the difference is because you are on a crlf-native
> platform while I am not...

I've got a test now. However, that test revealed some more related issues. I'll come up with a v2 of the patch this week.

-- 
Sebastian Schuberth
Previous: Sebastian Schuberth
Message 8 of 8 in “blame.c: Properly initialize strbuf after calling, textconv_object()”
  1. blame.c: Properly initialize strbuf after calling, textconv_object()Sebastian Schuberth, Oct 28, 2011
  2. Junio C HamanoOct 28, 2011
  3. Sebastian SchuberthOct 28, 2011
  4. Junio C HamanoOct 28, 2011
  5. Sebastian SchuberthOct 28, 2011
  6. Junio C HamanoOct 28, 2011
  7. Sebastian SchuberthOct 28, 2011
  8. Sebastian SchuberthOct 31, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.