Re: [PATCH 1/2] Makefile: Use the same source directory for "ln -s" as for "ln" / "cp"

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Feb 5, 2015, 19:26 UTC
Message-ID: <CAHGBnuP5e7NsDrD31otFGZiFYW-vxsOf7kV61=Zt32n3S78RBg@mail.gmail.com>
In-Reply-To: <xmqqmw4skvrn.fsf@gitster.dls.corp.google.com>

On Thu, Feb 5, 2015 at 8:23 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 26 quoted lines

>> This is wrong.
>>
>> Currently with symlinks you will get installed into bindir something
>> like this:
>>
>>   git
>>   git-tag -> git
>>   git-show -> git
>>
>> etc.
>>
>> With your change you would have
>>
>>   git
>>   git-tag -> /usr/local/libexec/git-core/git
>>   git-show -> /usr/local/libexec/git-core/git
>>
>> And I don't think we want that.  While those absolute path symlinks
>> are technically correct,...
>
> It is not even correct, is it?
>
> When DESTDIR is set to allow you to install into a temporary place
> only so that you can "tar" up the resulting filesystem tree, bindir
> points at the location we need to "cp" the built programs into, i.e.
> inside DESTDIR.

Agreed folks, please disregard this as well as 2/2 of this series.

-- 
Sebastian Schuberth