git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Solve git-submodule issues with detached work trees

From
Daniel Graña <dangra@gmail.com>
Date
Jul 23, 2012, 18:22 UTC
Message-ID
<CAHCkQtOCrCaF01fu-LS5jaTbiD7mxmWu0Mi5Dh1YCvcjdUkqLg@mail.gmail.com>
In-Reply-To
<500D8C30.9010807@web.de>
On Mon, Jul 23, 2012 at 2:38 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
Show 35 quoted lines
> Am 23.07.2012 07:09, schrieb Junio C Hamano:
>> Daniel Graña <dangra@gmail.com> writes:
>>
>>> A common way to track dotfiles with git is using GIT_DIR and
>>> GIT_WORK_TREE to move repository out of ~/.git with something like:
>>>
>>>     git init --bare ~/.dotfiles
>>>     alias dotfiles="GIT_DIR=~/.dotfiles GIT_WORK_TREE=~ git"
>>>
>>>     dotfiles add ~/.bashrc
>>>     dotfiles commit -a -m "add my bashrc"
>>>     ...
>>>
>>> but git-submodule complains when trying to add submodules:
>>>
>>>     dotfiles submodule add http://path.to/submodule
>>>     fatal: working tree '/home/user' already exists.
>>>
>>>     git --git-dir ~/.dotfiles submodule add http://path.to/submodule
>>>     fatal: /usr/lib/git-core/git-submodule cannot be used without a
>>> working tree.
>>>
>>> Signed-off-by: Daniel Graña <dangra@gmail.com>
>>> ---
>>
>> I think this is in line with what we discussed earlier on list when
>> the interaction between GIT_DIR/GIT_WORK_TREE and submodules came up
>> the last time.  Jens?
>
> Yes, I think this is the only way submodules in current git can
> be used with the GIT_DIR and GIT_WORK_TREE environment variables:
> set them when adding or initializing the submodule and always use
> the same settings when accessing them later. Daniel's dotfile
> alias achieves exactly that, so his fix looks good. But I agree
> the tests should be improved as you already pointed out.
Hi Jens, Junio.

Thanks for reviewing the patch, glad to hear this is acceptable way to fix my itch.

I will work soon on getting the test cases improved and the patch submitted without line wrapping.

thanks again, Daniel.

Previous: Junio C HamanoNext: Richard Hartmann
Message 9 of 11 in “Solve git-submodule issues with detached work trees”
  1. Solve git-submodule issues with detached work treesDaniel Graña, Jul 22, 2012
  2. Junio C HamanoJul 23, 2012
  3. Jens LehmannJul 23, 2012
  4. Junio C HamanoJul 23, 2012
  5. Jens LehmannJul 23, 2012
  6. Junio C HamanoJul 23, 2012
  7. Jens LehmannJul 23, 2012
  8. Junio C HamanoJul 23, 2012
  9. Daniel GrañaJul 23, 2012
  10. Richard HartmannJul 23, 2012
  11. Richard HartmannJul 23, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.