Re: [PATCH] git-submodule: a small fix

From: Andrew Ardill <andrew.ardill@gmail.com>
Date: Sep 27, 2011, 03:22 UTC
Message-ID: <CAH5451k-6HHx2xxddJauE8=P1umjG=TnrcOKmQfeh=4GOzpCKQ@mail.gmail.com>
In-Reply-To: <CAOOg04z0UjOQCBMTuii37y3ykNU17hDTcD9E81C+r1whFpMaCg@mail.gmail.com>

On 27 September 2011 08:00, Roy Liu <carsomyr@gmail.com> wrote:

Show 14 quoted lines

> In git-submodule.sh, the "url" variable may contain a stale value from
> the previous loop iteration, so clear it.
>
> --- git-submodule.sh.orig   2011-09-26 17:50:45.000000000 -0400
> +++ git-submodule.sh    2011-09-26 17:51:18.000000000 -0400
> @@ -370,6 +370,8 @@
>            esac
>            git config submodule."$name".url "$url" ||
>            die "Failed to register url for submodule path '$path'"
> +        else
> +            url=""
>        fi
>
>        # Copy "update" setting when it is not set yet

Perhaps a better commit description would be:

git-submodule: clear the url variable when not set to avoid using stale values

otherwise looks clean enough

Andrew