git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 4/7] bisect: introduce --no-checkout, --update-ref=<ref> support into porcelain.

From
Jon Seymour <jon.seymour@gmail.com>
Date
Jul 31, 2011, 19:40 UTC
Message-ID
<CAH3AnrqasW=ZSix0YBgxHg8ca2X+YOvSWknbG2mjsy0NaqV+Mw@mail.gmail.com>
In-Reply-To
<CAP8UFD2vCGnejSj=Nwkb+kGCpwUaggh5j2V6zBu0iWqNZwvS3Q@mail.gmail.com>

On Mon, Aug 1, 2011 at 5:21 AM, Christian Couder <christian.couder@gmail.com> wrote:

Show 10 quoted lines
> On Sun, Jul 31, 2011 at 1:55 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
>>
>> +       if test -n "$BISECT_UPDATE_REF"; then
>> +           eval="$eval echo '$BISECT_UPDATE_REF' > '$GIT_DIR/BISECT_UPDATE_REF';"
>> +       fi
>
> I don't like this very much. In fact I realize that the eval thing we
> use is buggy because the result of 'eval "eval"' will be the result of
> the last command in "eval", so we won't detect if one of the first
> command in "eval" failed.

How about I fix the eval stitching so that it uses && rather than ; to connect each statement with a final true at the end so there is no dangling &&?

Show 8 quoted lines
>
> So perhaps something like:
>
>    eval "$eval" &&
> +  ( test -n "$BISECT_UPDATE_REF" || echo "$BISECT_UPDATE_REF" >
> "$GIT_DIR/BISECT_UPDATE_REF" ) &&
>    echo "git bisect start$orig_args" >>"$GIT_DIR/BISECT_LOG" || exit
>
Probably this would be better :-)
( test -z "$BISECT_UPDATE_REF" || echo "$BISECT_UPDATE_REF" >
 "$GIT_DIR/BISECT_UPDATE_REF" ) &&
jon.
Previous: Christian CouderNext: Christian Couder
Message 10 of 17 in “bisect: Add support for --no-checkout and --update-ref=<ref> options.”
  1. 0/7 bisect: Add support for --no-checkout and --update-ref=<ref> options.Jon Seymour, Jul 31, 2011
  2. 1/7 bisect: move argument parsing before state modification.Jon Seymour, Jul 31, 2011
  3. 2/7 bisect: add tests to document expected behaviour in presence of broken trees.Jon Seymour, Jul 31, 2011
  4. 3/7 bisect: introduce support for --update-ref=<ref> option.Jon Seymour, Jul 31, 2011
  5. 4/7 bisect: introduce --no-checkout, --update-ref=<ref> support into porcelain.Jon Seymour, Jul 31, 2011
  6. Christian CouderJul 31, 2011
  7. Jon SeymourJul 31, 2011
  8. Christian CouderJul 31, 2011
  9. Christian CouderJul 31, 2011
  10. Jon SeymourJul 31, 2011
  11. Christian CouderJul 31, 2011
  12. Christian CouderJul 31, 2011
  13. Jon SeymourJul 31, 2011
  14. 5/7 bisect: add tests for the --no-checkout and --update-ref options.Jon Seymour, Jul 31, 2011
  15. 6/7 bisect: add documentation for --no-checkout and --update-ref=<ref> options.Jon Seymour, Jul 31, 2011
  16. 7/7 bisect: support --update-ref <ref>Jon Seymour, Jul 31, 2011
  17. Jon SeymourJul 31, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.