Re: [RFC] submodule: fix handling of supermodules with relative origin URLs.

From: Jon Seymour <jon.seymour@gmail.com>
Date: May 18, 2012, 21:45 UTC
Message-ID: <CAH3AnrqXbUuKKWzAf9_xHtu-c5sYGRf5dj+CqOmOmesnwh8=pg@mail.gmail.com>
In-Reply-To: <4FB6A9CB.5050702@web.de>

On Sat, May 19, 2012 at 5:58 AM, Jens Lehmann <Jens.Lehmann@web.de> wrote:

> This version of the patch does break some existing tests, but your
> follow up suggests you already found that out yourself ;-)
>

Actually, that was just by reading the patch and noticing odd-ness. I realise now that I snuck in that bogus edit after I had run the tests which were otherwise clean - d'oh.

>
> Me thinks up_path should be set in the case below, which is the only
> place where it is used.

Ok.

>
> Isn't sm_path already set correctly here? I think this line should
> be dropped.
>

Yes, good point. Thanks.

>
> Same here.
>

Thanks.

>
> Other than that the patch looks fine.

Thanks for the review - I'll add some tests for the new behaviour.

jon.