git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 0/9] bisect: allow git bisect to be used with repos containing damaged trees.

From
Jon Seymour <jon.seymour@gmail.com>
Date
Jul 26, 2011, 13:28 UTC
Message-ID
<CAH3AnroGQML+FV_Zh9u35bOBed00bk3qcQ1qA==RpmtTv1zz2w@mail.gmail.com>
In-Reply-To
<m3ei1dsd1x.fsf@localhost.localdomain>
Show 15 quoted lines
> Which means that it works in this case:
>
>
>                        bad bad bad
>                   BAD
>   good good good
>
>
> but won't work in this case:
>
>
>
>   good good good               good good good
>                   bad bad bad
>

Of course, this doesn't mean that bisection is useless, only that you have to choose the right kind of test!

So, while it is true that a commit local test such as those I was proposing (e.g. git ls-tree or even my suggested tweak git rev-list --objects --max-count=1) will be useless unless you happen to start with the tip at the bad commit, it is not true that bisection in general is useless.

For example, Junio's unconstrained git rev-list --objects | git pack-objects test will be sufficient because a history that is

    good good good bad bad bad good good good
according to a commit local test, will be:
     bad bad bad bad bad bad bad good good good

from the point of view of a test that reaches the entire graph reachable from a commit.

It will still be beneficial to do log(N) executions of git rev-list --objects instead of N executions of the same.

jon.
Previous: Jon Seymour
Message 21 of 21 in “[RFC 0/9] bisect: allow git bisect to be used with repos containing damaged trees.”
  1. Jon SeymourJul 24, 2011
  2. 1/9 bisect: add tests to document expected behaviour in presence of broken trees.Jon Seymour, Jul 24, 2011
  3. 2/9 bisect: introduce a --ignore-checkout-failure option to bisect--helper.Jon Seymour, Jul 24, 2011
  4. 3/9 bisect: implement support for --ignore-checkout-failure optionJon Seymour, Jul 24, 2011
  5. 4/9 bisect: introduce a helper function to tolerate checkout failures.Jon Seymour, Jul 24, 2011
  6. 5/9 bisect: replace existing calls to git checkout with bisect_checkout_with_ignoreJon Seymour, Jul 24, 2011
  7. 6/9 bisect: enable --ignore-checkout-failure in the porcelain.Jon Seymour, Jul 24, 2011
  8. 7/9 bisect: better diagnostics, in case of mis-typed option.Jon Seymour, Jul 24, 2011
  9. 8/9 bisect: add tests for --ignore-checkout-failure option.Jon Seymour, Jul 24, 2011
  10. 9/9 bisect: add documentation for --ignore-checkout-failure option.Jon Seymour, Jul 24, 2011
  11. Johannes SixtJul 24, 2011
  12. Jon SeymourJul 24, 2011
  13. Junio C HamanoJul 24, 2011
  14. Jon SeymourJul 25, 2011
  15. Junio C HamanoJul 25, 2011
  16. Jon SeymourJul 25, 2011
  17. Johannes SixtJul 25, 2011
  18. Jon SeymourJul 25, 2011
  19. Jakub NarebskiJul 26, 2011
  20. Jon SeymourJul 26, 2011
  21. Jon SeymourJul 26, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.