git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Cover letter for the last patch

From
jaseem abid <jaseemabid@gmail.com>
Date
Jun 12, 2012, 06:03 UTC
Message-ID
<CAH-tXsCn+9t5dAq6ujNTvWL5Gz_Cw5nRLzwVjxw6-t8Hhwg4Aw@mail.gmail.com>
Dear list,
Sorry,  I think i missed the cover letter for the last patch.
[PATCH/RFC] gitweb: Adding jasmine test suite files for the browser

JavaScript in gitweb is almost completely handwritten. It is reimplementing things JavaScript library authors did a lot of times already. Porting the current code to a library version was proposed as a gsoc project this year. [ So I think I can skip why this patch is relevant]

A common suggestion was to add tests to the new JavaScript code. Deciding the testing framework took much more time than expected after several discussions. People wanted tests that could be run in console with TAP so that it will integrate well with the existing system but since the code is ultimately going to be run in a browser, tests in the browser was more important.

After a lot of discussions here and on #git-devel, I have used jasmine BDD framework, nodejs and jasmine TAP reporter to solve the issues. The specs are written for the browser and a makefile generates t/t9503-gitweb-javascript.js which can be run in a console to produce TAP output.

This patch series is for review only. If everyone is ok with the new testing framework, I will be able to send a patch with actual code in a week or 2. This patch series adds few sample tests to the existing code, and makes it run in a browser and console.

I have added gitweb/test/README with instructions on the new test.

Please eyeball the changes to t/Makefile as I am not very sure if that is the best way to do it.

Reviews most welcome.
-- 
Jaseem Abid
http://jaseemabid.github.com
Message 1 of 1 in “Cover letter for the last patch”
  1. jaseem abidJun 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.