git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] repo: zero-initialize configuration values

From
JJJoie Joie <soniqjjj@gmail.com>
Date
Nov 6, 2026, 16:19 UTC
Message-ID
<CAH=d44eGRgHOF1NX0t6+OJP4GVhTqnvQi+sgnM86CC4FE_4LsA@mail.gmail.com>
In-Reply-To
<au3hVGPuDyGVwOw8@pks.im>
Thanks, Patrick.

Yes, that was my reason for splitting the patch. It only changes how the existing configuration values are initialized and doesn't add a new struct member, so I felt it could be reviewed separately from the changes affected by the recent direction.

You're right, though. I should have explained that more clearly in the patch description and the original thread. I'll make sure to include that context in future submissions.

Thanks for taking the time to review it!
On Fri, Nov 6, 2026 at 3:16 PM Patrick Steinhardt <ps@pks.im> wrote:
Show 21 quoted lines
>
> On Fri, Nov 06, 2026 at 11:59:28AM +0000, Joy via GitGitGadget wrote:
> > From: Joy Gundu <soniqjjj@gmail.com>
> >
> > Use memset() to initialize repository configuration values to
> > zero, removing the need for explicit zero and NULL assignments.
> > Keep non-zero defaults initialized separately.
> >
> > Signed-off-by: Joy Gundu <soniqjjj@gmail.com>
> > ---
> >     [Outreachy] repo: zero-initialize configuration values
>
> So I guess this patch was split out because of our recent push to not
> make further changes to `repo_config_values()`? If so, it would have
> made sense to point that out explicitly both here, and in the original
> thread that you've sent.
>
> In any case, the patch is obviously correct and is a good improvement in
> my opinion. So this looks good to me, thanks.
>
> Patrick
Previous: Patrick SteinhardtNext: Junio C Hamano
Message 3 of 6 in “repo: zero-initialize configuration values”
  1. repo: zero-initialize configuration valuesJoy via GitGitGadget, Nov 6, 2026
  2. Patrick SteinhardtNov 6, 2026
  3. Joie JoieNov 6, 2026
  4. Junio C HamanoNov 6, 2026
  5. Joie JoieNov 9, 2026
  6. Junio C HamanoNov 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.