git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix upload-pack EOF death in normal stateless negotiation

From
Bryan Turner <bturner@atlassian.com>
Date
Oct 30, 2020, 00:32 UTC
Message-ID
<CAGyf7-HOkt3bCkJ+qshb0AFZSt2f=NmvHb3Gh1m2dzLWpYHozQ@mail.gmail.com>
In-Reply-To
<CANo+1gtVRj30-JNPFpqc_m3BSEFzcb8-T+-uJTFvnNuBZYYxQQ@mail.gmail.com>
On Thu, Oct 29, 2020 at 4:53 PM Daniel Duvall <dan@mutual.io> wrote:
Show 18 quoted lines
>
> Hi there,
>
> I noticed while debugging an issue in Phabricator where shallow git
> fetches over HTTP were failing with 500 errors that `git-http-backend`
> seemed to exit abnormally after the first request even though the
> response was otherwise correct—and when the error is not surfaced to
> the client, the packfile negotiation via `git-remote-curl` seems to
> continue normally.[1]
>
> I think this patch fixes the issue by having `upload-pack` gently
> handle EOFs at a specific point in negotiation—after shallow/unshallow
> lines have been returned to the client (followed by flush) but before
> the client sends its haves.
>
> This is my first contribution here so hopefully I'm understanding the
> packfile negotiation protocol correctly and included my test in the
> right place.

Have you read Documentation/SubmittingPatches? It has some guidelines (like submitting patches inline, rather than as attachments) you'll want to ensure you've followed.

Show 5 quoted lines
>
> Kindly,
> Daniel
>
> [1] https://discourse.phabricator-community.org/t/git-fetches-with-depth-over-http-results-in-500-errors/4317
Previous: Daniel DuvallNext: Daniel Duvall
Message 2 of 3 in “Fix upload-pack EOF death in normal stateless negotiation”
  1. Fix upload-pack EOF death in normal stateless negotiationDaniel Duvall, Oct 29, 2020
  2. Bryan TurnerOct 30, 2020
  3. Daniel DuvallOct 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.