Re: [PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https://.
- From
Bryan Turner <bturner@atlassian.com>
- Date
- Jan 29, 2013, 04:16 UTC
- Message-ID
- <CAGyf7-Gub7pFY+NpX0Cp4p9bUyzZHfp6qj+b5uNOEgHfhSJykw@mail.gmail.com>
- In-Reply-To
- <20130129041206.GA15442@google.com>
Interesting. I wonder if they've changed it recently. I only pointed it out because a software product I'm working on had a bug because it was building the URLs with "https://www..." and the resulting images were showing as X's instead of avatars. We had to change the implementation to use "https://secure..." to get the avatars to load correctly. That's been ~8 months ago now, though, so maybe it's no longer the case. It seems like it would be much more convenient if they just changed the scheme.
Bryan
On 29 January 2013 15:12, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 12 quoted lines
> Hi Bryan, > > Bryan Turner wrote: > >> This won't work correctly as-is. The secure URL for Gravatar is >> "https://secure.gravatar.com"[1], not "https://www.gravatar.com". > > Odd. "https://www.gravatar.com/" also seems to work. I've put in a > technical support query to find out what the Gravatar admins prefer. > > Thanks, > Jonathan