Re: [git-for-windows] Git for Windows v2.25.0-rc2, was Re: [ANNOUNCE] Git v2.25.0-rc2

From: Bryan Turner <bturner@atlassian.com>
Date: Jan 9, 2020, 22:38 UTC
Message-ID: <CAGyf7-EgDYBZ-=o6g4HV3rywreD=QvRr8R0agr=0UMbq_ib5Hw@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.2001092244250.46@tvgsbejvaqbjf.bet>

On Thu, Jan 9, 2020 at 1:47 PM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 21 quoted lines

>
> Team,
>
> On Wed, 8 Jan 2020, Junio C Hamano wrote:
>
> > A release candidate Git v2.25.0-rc2 is now available for testing
> > at the usual places.  It is comprised of 517 non-merge commits
> > since v2.24.1, contributed by 70 people, 29 of which are new faces.
> >
> > The tarballs are found at:
> >
> >     https://www.kernel.org/pub/software/scm/git/testing/
>
> The corresponding Git for Windows v2.25.0-rc2 can be found here:
>
>         https://github.com/git-for-windows/git/releases/tag/v2.25.0-rc2.windows.1
>
> In addition to rebasing Git for Windows' patches from v2.25.0-rc1 onto
> v2.25.0-rc2, this also includes the "mingw: safeguard better against
> backslashes in file names" fix that I sent upstream in
> https://lore.kernel.org/git/pull.690.git.git.1578576634678.gitgitgadget@gmail.com/

I just wanted to say thank you for the work you've done adding, and then refining, these backslash checks! The `core.protectNTFS` changes in 2.24.1 caused some pretty significant fallout with our testing repositories, multiple of which have invalid trees due to backslashes. Our Windows tests don't use any of those trees, though, so the checks were frustratingly rigid (if understandable, I should add).

One further thing we found while trying to make adjustments to our test suite to account for the 2.24.1 changes was that, for some actions, we couldn't find a way to make `core.protectNTFS=false` actually change behavior. For example, using something like `git -c core.protectNTFS=false fetch /path/on/disk` still failed due to invalid trees (as has been mentioned on other threads, I believe).

Anyway, thanks again for these early release candidates, and for your efforts to polish the backslash checks to retain the protections but loosen the restrictions.

Best regards, Bryan Turner

Show 8 quoted lines

>
> Ciao,
> Johannes
>
> --
> You received this message because you are subscribed to the Google Groups "git-for-windows" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to git-for-windows+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/git-for-windows/nycvar.QRO.7.76.6.2001092244250.46%40tvgsbejvaqbjf.bet.