git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 0/2] svn-fetch|push - an alternate approach

From
James McKaskill <james@foobar.co.nz>
Date
Aug 22, 2012, 02:30 UTC
Message-ID
<CAGwq8_4nKKN5jjR8Z7qvDzuoTjYhjYiudhnPHD-JLgnASAdCKQ@mail.gmail.com>
In-Reply-To
<5033336C.4050906@alum.mit.edu>
On Tue, Aug 21, 2012 at 3:06 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
Show 10 quoted lines
> On 08/19/2012 12:21 PM, Marco Schulze wrote:
>> It is a bit of a pain to work with libsvn, but I think it is worth using
>> it, not only due to protocol support, but also due to ready-to-use
>> support for SVN deltas and dumps.  Pipelining could be implemented by
>> maintaining a set of connections (svn_ra_session_t structures) and
>> manually distributing work between them.
>
> Using libsvn would also have the benefit of letting the Subversion
> project worry about forwards and backwards compatibility if the protocol
> ever changes.  (They tend to be quite diligent about that.)

So my goal with the svn support is not so much to support pushing to svn, but to support it natively. What I mean by that is that it will use the git configuration for http, auth, ssl, etc. For the svn protocol there is little to none of this, but frankly the svn protocol is a one to one mapping to the svn editor interface and very simple to boot. So working off the interface vs working off of the protocol there isn't much different in the complexity or amount of code. For HTTP though there is a huge benefit to working outside libsvn. Namely reusing the http support in git means all of the credential, http, ssl config works. Also these days again there isn't much difference between the http interface and the svn editor interface.

As for diffs and dumps ... Well svn diff parsing and generation is relatively trivial (200-300 lines currently). I have no real plan currently to deal with dumps.

I've since added support for HTTP. What I'll do is add a third interface in the same manner that uses libsvn. If it turns out simple enough then that would be the way to go for dumps and svn, but I'm very skeptical about using that for HTTP+svn (can't be fully sure without trying I suppose).

TLDR: You've convinced me to at least give it a try.
-- James
Previous: Michael Haggerty
Message 6 of 6 in “[RFC 0/2] svn-fetch|push - an alternate approach”
  1. James R. McKaskillAug 18, 2012
  2. 1/2 add svn-fetch/pushJames R. McKaskill, Aug 18, 2012
  3. 2/2 add tests for git svn-fetch|pushJames R. McKaskill, Aug 18, 2012
  4. Marco SchulzeAug 19, 2012
  5. Michael HaggertyAug 21, 2012
  6. James McKaskillAug 22, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.