Re: git pull defaults for recursesubmodules

From: Tommi Vainikainen <tvainika@gmail.com>
Date: Oct 24, 2018, 05:32 UTC
Message-ID: <CAGshahmzPyC65g6dWSqucDckoxyv=uKQLuHR8aKRFdbSp3KaJQ@mail.gmail.com>
In-Reply-To: <CAGZ79kZf8owJUkYF2SsCr_2q8hKxZW_Z3SbUQr6YMgNh8THfXQ@mail.gmail.com>

ke 24. lokak. 2018 klo 0.57 Stefan Beller (sbeller@google.com) kirjoitti:

Show 8 quoted lines

> On Tue, Oct 23, 2018 at 2:04 PM Tommi Vainikainen <tvainika@gmail.com> wrote:
> > I would expect that if git-config has fetch.recurseSubmodules set,
> > also git pull should use this setting, or at least similar option such
>
> This makes sense to me and the patch looks good to me.
> It is unclear to me if this is a regression or an oversight of
> of a6d7eb2c7a (pull: optionally rebase submodules (remote
> submodule changes only), 2017-06-23)

With my testing, no it was not regression at least from that commit. It did not work as I expected before that commit.

What was unclear to me is why this config needs to be read as pull calls fetch, why fetch does not use this configuration as is? If fetch.prune=1, should git pull command also prune or not during fetch? There does not seem to be test case for that behavior.

-- 
Tommi Vainikainen