git-gui: duplicated key binds?
- From
Birger Skogeng Pedersen <birger.sp@gmail.com>
- Date
- Sep 18, 2019, 11:24 UTC
- Message-ID
- <CAGr--=KC=OPMJZB883MWys=J068cdZNHL=eOYK81fNBEv9MhvA@mail.gmail.com>
Hi,
It looks to me like there are a lot of key binds duplicated in the git-gui source.
For instance, Ctrl/Cmd+Enter are bound in two lines: bind $ui_comm <$M1B-Key-Return> {do_commit;break} and bind . <$M1B-Key-Return> do_commit
I guess the first one is specified to work in the commit message widget. The second one is for all widgets(?).
Also, I see that some binds are with the "all" tag, while most are with just a dot as tag.
Is this a mistake (aka something I could write a patch for)? Or am I just missing something?
[0] https://github.com/prati0100/git-gui/blob/master/git-gui.sh#L3835-L3928
I propose: - replace "bind . " with "bind all " - remove duplicated bind entries, if a key is bound to "all" then it shouldn't be bound with another tag
Birger