git/list[1] front-page[2] threads[3] people[4] search[5] about
 

git-gui: duplicated key binds?

From
Birger Skogeng Pedersen <birger.sp@gmail.com>
Date
Sep 18, 2019, 11:24 UTC
Message-ID
<CAGr--=KC=OPMJZB883MWys=J068cdZNHL=eOYK81fNBEv9MhvA@mail.gmail.com>
Hi,

It looks to me like there are a lot of key binds duplicated in the git-gui source.

For instance, Ctrl/Cmd+Enter are bound in two lines: bind $ui_comm <$M1B-Key-Return> {do_commit;break} and bind . <$M1B-Key-Return> do_commit

I guess the first one is specified to work in the commit message widget. The second one is for all widgets(?).

Also, I see that some binds are with the "all" tag, while most are with just a dot as tag.

Is this a mistake (aka something I could write a patch for)? Or am I just missing something?

[0] https://github.com/prati0100/git-gui/blob/master/git-gui.sh#L3835-L3928
I propose:
- replace "bind .   " with "bind all "
- remove duplicated bind entries, if a key is bound to "all" then it
shouldn't be bound with another tag
Birger
Next: Birger Skogeng Pedersen
Message 1 of 3 in “git-gui: duplicated key binds?”
  1. Birger Skogeng PedersenSep 18, 2019
  2. Birger Skogeng PedersenSep 18, 2019
  3. Pratyush YadavSep 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.