Re: [PATCH] fetch-pack: grow stateless RPC windows exponentially
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Jul 18, 2016, 19:16 UTC
- Message-ID
- <CAGf8dgJVkkVwJ5aJCQBcYKw7F9g7u3pMsuJHedSGLG6PQk2Keg@mail.gmail.com>
- In-Reply-To
- <xmqq37n6kbib.fsf@gitster.mtv.corp.google.com>
On Mon, Jul 18, 2016 at 12:10 PM, Junio C Hamano <gitster@pobox.com> wrote:
> I'd understand if it were more like "aggressive exponential -> > conservative exponential" without linear phase when stateless_rpc is > in use, though. I just do not quite understand the justification > behind the order of three phases introduced by this change.
Adding conservative exponential phase after the aggressive exponential phase was the original intention, but the conservative exponential approach (e.g. n' = n * 11 / 10) is slower than the existing linear (n' = n + 1024) approach when n < 10240, so I added that intermediate phase to avoid a regression in the packet size growth.