git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] rebase -i: interrupt rebase when "commit --amend" failed

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Jul 30, 2011, 11:52 UTC
Message-ID
<CAGdFq_in9huck5kGo5N00jF53B2USsHy_CXb914jZrMZ4HpTUg@mail.gmail.com>
In-Reply-To
<1311565113-5022-3-git-send-email-andrew.kw.w@gmail.com>
Heya,
On Mon, Jul 25, 2011 at 05:38, Andrew Wong <andrew.kw.w@gmail.com> wrote:
Show 6 quoted lines
> "commit --amend" could fail if the user empties the commit message.
> Although this is not a real error, it seems to make more sense to
> interrupt the rebasing, rather than ignoring the error and continue on
> rebasing.  This gives users a way to gracefully interrupt a "reword" if
> they decided they actually want to do an "edit", or even "rebase
> --abort".

Yesplease. I've had this where I marked an entire patch series for reword only to discover on the first patch that I made a mistake, so I ended up having to type ":wq" some twenty times. It would have been much nicer if I could just have done ":cq" once and then 'git rebase --abort'.

-- 
Cheers,

Sverre Rabbelier
Previous: Andrew Wong
Message 4 of 4 in “rebase -i: Some nice-to-have behaviors for "reword"”
  1. 0/2 rebase -i: Some nice-to-have behaviors for "reword"Andrew Wong, Jul 25, 2011
  2. 1/2 rebase -i: run "commit --amend" with verbose if rebase was called with -vAndrew Wong, Jul 25, 2011
  3. 2/2 rebase -i: interrupt rebase when "commit --amend" failedAndrew Wong, Jul 25, 2011
  4. Sverre RabbelierJul 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.