Re: [PATCH 2/2] obstack.c: Fix some sparse warnings

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Sep 11, 2011, 21:56 UTC
Message-ID: <CAGdFq_ifU2WWbCpRY_EFY=_hwwtFs0eqMhJ7sRoUhrivABFoFw@mail.gmail.com>
In-Reply-To: <4E6D0B7D.9070602@ramsay1.demon.co.uk>

Heya,

On Sun, Sep 11, 2011 at 21:26, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

>    compat/obstack.c:399:1: error: symbol 'print_and_abort' redeclared with \
>        different type (originally declared at compat/obstack.c:95) \
>        - different modifiers

Show 8 quoted lines

> @@ -395,7 +395,6 @@ _obstack_memory_used (struct obstack *h)
>  # endif
>
>  static void
> -__attribute__ ((noreturn))
>  print_and_abort (void)
>  {
>   /* Don't change any of these strings.  Yes, it would be possible to add

Wouldn't the better solution be to add noreturn to the declaration at compat/obstack.c:95?

-- 
Cheers,

Sverre Rabbelier