Re: [PATCH v2] send-email: extract email-parsing code into a subroutine

From: Nathan PAYRE <second.payre@gmail.com>
Date: Dec 6, 2017, 22:55 UTC
Message-ID: <CAGb4CBWZciqxdfpSkK1vezhiuSYX5Yy-xSq=Uj4h+vhRo9uyoQ@mail.gmail.com>
In-Reply-To: <xmqqvahjfsdx.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com>: writes:

> ... throughout this patch, not limited to this section, indentation
> is strange and there seem to be many "print" that show messages that
> do not seem to be meant for end-user consumption.  I can see that
> this aspires to improve the readability, but not quite yet ;-).

Hmmm I'm wondering who place thoses print in my code ! I will fix it fast. :-)

Show 5 quoted lines

> Also "reusable in other place" is by itself not an unconditional
> plus, until readers can be convinced that that 'other place' really
> wants to be able to call this function.  Is there some untold
> motivation behind this change---such as a planned update to actually
> use this helper subroutine?

This subroutine will be used to implement, initially a new option called "--quote-email", but became "--cite" added after "--in-reply-to". This will permit to the user to cite a mail and reply with a patch and keep Cc, To ... See discussion : https://public-inbox.org/git/20171030223444.5052-1-nathan.payre@etu.univ-lyon1.fr/

And Daniel Timothee and I wanted to refactor an other part of the file using parse_header_line(). Near Line 1570.