Re: [PATCH v2 00/12] Improve "refs" module encapsulation
On Sat, Jun 13, 2015 at 7:42 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> This is v2 of this patch series. I think I have addressed all of the
> feedback from v1 [1]. Thanks to Stefan, Peff and Junio for their
> feedback.
This version looks good to me.
Show 48 quoted lines
>
> Changes since v1:
>
> * Change docstring for delete_ref() and a comment within the function
> definition.
>
> * Squash together two commits dealing with the error message in
> delete_refs().
>
> These patches are also available from my GitHub account [2] as branch
> "init-delete-refs-api".
>
> Michael
>
> [1] http://thread.gmane.org/gmane.comp.version-control.git/271017
> [2] https://github.com/mhagger/git
>
> Michael Haggerty (12):
> delete_ref(): move declaration to refs.h
> remove_branches(): remove temporary
> delete_ref(): handle special case more explicitly
> delete_refs(): new function for the refs API
> delete_refs(): improve error message
> prune_remote(): use delete_refs()
> repack_without_refs(): make function private
> initial_ref_transaction_commit(): function for initial ref creation
> refs: remove some functions from the module's public interface
> initial_ref_transaction_commit(): check for duplicate refs
> initial_ref_transaction_commit(): check for ref D/F conflicts
> refs: move the remaining ref module declarations to refs.h
>
> archive.c | 1 +
> builtin/blame.c | 1 +
> builtin/clone.c | 19 ++++-
> builtin/fast-export.c | 1 +
> builtin/fmt-merge-msg.c | 1 +
> builtin/init-db.c | 1 +
> builtin/log.c | 1 +
> builtin/remote.c | 33 +-------
> cache.h | 68 ----------------
> refs.c | 171 ++++++++++++++++++++++++++++++++++++---
> refs.h | 211 +++++++++++++++++++++++++++++++-----------------
> remote-testsvn.c | 1 +
> 12 files changed, 321 insertions(+), 188 deletions(-)
>
> --
> 2.1.4
>
Stefan Beller <sbeller@google.com>