Re: [PATCH] grep: handle corrupt index files early

From: Stefan Beller <sbeller@google.com>
Date: May 17, 2018, 17:21 UTC
Message-ID: <CAGZ79kbvjoTq5079Ks+h2HNb+D99RELYPcJk2=pvZf9-Y8dToQ@mail.gmail.com>
In-Reply-To: <xmqqbmdf6p1t.fsf@gitster-ct.c.googlers.com>

On Wed, May 16, 2018 at 6:36 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Duy Nguyen <pclouds@gmail.com> writes:
>
>> With a majority of call sites dying like this though, I wonder if we
>> should just add repo_read_index_or_die() with die() inside. Then the
>> next person won't likely accidentally forget _()
>
> Yuck.
>
> That sounds like inviting a major code churn.  I tend to agree that
> it would be a good clean-up for longer term maintenance, but I am
> not sure if I can honestly say I'd look forward to such a clean-up
> at this point in the cycle when there are tons of large-ish topics
> in flight X-<.

ok, consider the series https://public-inbox.org/git/20180516222118.233868-1-sbeller@google.com/ retracted for this cycle; I will keep it around and resend it at some future date, hopefully.

Feel free to comment on it, though.

Stefan