Re: [PATCH 6/8] run-command: add an asynchronous parallel child processor
- From
Stefan Beller <sbeller@google.com>
- Date
- Dec 14, 2015, 21:40 UTC
- Message-ID
- <CAGZ79kbseHv+gbjxFHH8nO_QV-8SS+7u=LYVQ0_K5u39rD0uGQ@mail.gmail.com>
- In-Reply-To
- <566F28EA.3080802@kdbg.org>
On Mon, Dec 14, 2015 at 12:39 PM, Johannes Sixt <j6t@kdbg.org> wrote:
Show 10 quoted lines
> > I can't quite parse the first sentence in this paragraph. Perhaps something > like this: > > To detect when a child has finished executing, we check interleaved > with other actions (such as checking the liveliness of children or > starting new processes) whether the stderr pipe still exists. Once a > child closed its stderr stream, we assume it is terminating very soon, > and use finish_command() from the single external process execution > interface to collect the exit status.
Sounds much better than my words. If a resend is necessary, I'll have your reworded version of the paragraph instead.
Show 10 quoted lines
> > >> >> By maintaining the strong assumption of stderr being open until the >> very end of a child process, we can avoid other hassle such as an >> implementation using `waitpid(-1)`, which is not implemented in Windows. >> >> Signed-off-by: Stefan Beller <sbeller@google.com> > >