Re: [PATCH] Re: Bug with "git submodule update" + subrepo with differing path/name?

From: Stefan Beller <sbeller@google.com>
Date: Dec 19, 2017, 22:33 UTC
Message-ID: <CAGZ79kbqntXuYuLGF7zjXfQ5X998QdEba20yy8A0cqS=DaRxFA@mail.gmail.com>
In-Reply-To: <xmqqk1xitl6l.fsf@gitster.mtv.corp.google.com>

On Tue, Dec 19, 2017 at 2:19 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> I tried reproducing the issue (based on the `next` branch, not 2.15,
>> but I do not recall any changes in the submodule area lately), and
>> could not come up with a reproduction recipe,...
>
> I do not offhand recall anything; the closest I can think of is the
> three-patch series <20171016135623.GA12756@book.hvoigt.net> that
> taught the on-demand recursive fetch to pay attention to the location
> in the superproject tree a submodule is bound to.

I tried the same test on 2.15 and cannot reproduce there either.

Show 6 quoted lines

>
>     4b4acedd61 submodule: simplify decision tree whether to or not to fetch
>     c68f837576 implement fetching of moved submodules
>     01ce12252c fetch: add test to make sure we stay backwards compatible
>
> But IIRC, "submodule update" uses a separate codepath?

Yes, any portion of git-submodule.sh that calls out to C is going through the submodule--helper. I want to revive the port of that shell script to C again.

The "submodule update" uses the submodule helper to obtain the list of submodules and then does a "git -C $sub fetch" in there.

Stefan