Re: [PATCHv2 1/8] run_processes_parallel: Add output to tracing messages
- From
Stefan Beller <sbeller@google.com>
- Date
- Oct 30, 2015, 17:32 UTC
- Message-ID
- <CAGZ79kbmkwiQYSqtvn0kTCqh6XfkkcfxN1exTXzr8FOz4pWDQw@mail.gmail.com>
- In-Reply-To
- <CAPig+cToAFAPhhFhOd_MF+EUcvRUjWOooeZH4uDy3-d9GEq73g@mail.gmail.com>
On Thu, Oct 29, 2015 at 6:10 PM, Eric Sunshine <ericsunshine@gmail.com> wrote:
Show 6 quoted lines
> On Wed, Oct 28, 2015 at 7:21 PM, Stefan Beller <sbeller@google.com> wrote: >> run_processes_parallel: Add output to tracing messages > > This doesn't really say much. I guess you mean that the intention is > to delimit a section in which output from various tasks may be > intermixed.
My original intention is to have it there for testing in later patches, so I am not so much interested in the delimiting but the raw number %d here.
> run_processes_parallel: delimit intermixed task output
Sounds good to me, better than my subject.
> s/children/tasks/ maybe? > > Minor: Perhaps drop "in parallel" since the parallelism is already > implied by the "run_processes_parallel" prefix.
done
Show 5 quoted lines
>> + trace_printf("run_processes_parallel: parallel processing done");
>
> Minor: Likewise, perhaps just "done" rather than "parallel processing
> done" since the "run_processes_parallel" prefix already implies
> parallelism.done