Re: [PATCH 2/4] t1000: modernize style

From: Stefan Beller <sbeller@google.com>
Date: Jan 10, 2017, 20:43 UTC
Message-ID: <CAGZ79kbm4GRwNe7J_KP_V3eP8ZyAMEhOy-HL_ytHGtPoe19NPg@mail.gmail.com>
In-Reply-To: <xmqqr34ar6s1.fsf@gitster.mtv.corp.google.com>

On Tue, Jan 10, 2017 at 12:37 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> The preferred style in tests seems to be
>
> s/seems to be/is/;

If this is the only nit, mind to fix up the commit message locally? (I was even unsure if we want to have this patch as part of a larger series, as it is just refactoring for the sake of refactoring, i.e. t1000 doesn't see a new test in this series, only t1001 does)

Show 10 quoted lines

>
>>
>> test_expect_success 'short description, ended by 2 single quotes' '
>>       here comes the test &&
>>       and chains over many lines &&
>>       ended by a quote
>> '
>
> Thanks.  This is way overdue.  During the time the script has been
> dormant for more than two years, we should have done this.

agreed.